fix(web-ui): hide internal gateway tools from selectors - #1588
Merged
Conversation
Hide GetToolSpec and CallDeferredTool from agent and assistant tool selection surfaces while preserving existing configured gateway entries. Add shared tool visibility filtering and focused unit coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hide the internal gateway tools
GetToolSpecandCallDeferredToolfrom user-facing tool selection surfaces.This change:
Fixes #1564
Type and Areas
Type:
Bug fix / UI/UX / test
Areas:
Web UI, Agent Scene, Assistant Defaults
Motivation / Impact
GetToolSpecandCallDeferredToolare internal gateway tools used by the deferred-tool mechanism. When users add them to an agentic mode'sadded_tools, they may be returned by the tool registry and exposed in user-facing tool selectors.Users should not select or manage these internal gateway tools directly. They are now hidden from the relevant Web UI surfaces and excluded from displayed tool counts.
Existing configurations containing these tools are preserved when users modify other tools, so this UI protection does not unexpectedly rewrite or remove legacy configuration entries.
Verification
pnpm run type-check:webpnpm run lint:webpnpm --dir src/web-ui run test:run src/shared/utils/toolVisibility.test.tspnpm --dir src/web-ui exec vitest run src/app/scenes/agents/AgentsScene.test.tsx --testTimeout=30000git diff --checkReviewer Notes
GetToolSpecandCallDeferredToolentries are intentionally preserved when another tool is toggled or an agent-card tool configuration is saved.Checklist